windows icon is old

[azakhary]

on windows builds icon is outdated, need fixing all icons across all platform builds according to one in the osx version

[azakhary]

Info shared by @kustomzone

• the build\icons\png\1024x1024.png is a copy the 512x512.png ..just renamed. Linux uses 512x512 png.
• the current build\icons\win\icon.ico (despite being 360kb) is only 128x128 and renders badly. (see attached image)
• Electron apps on Windows use 256x256 pixels. (attached it, but Discord deleted my post without warning)
• Electron Windows apps support different icon sizes such as the dock icon or the icon in the system tray, which can be smaller, like 16x16 or 32x32 pixels. - These also need to be .ico format.
• All the PNGs in build\icons\png\ (256x256 and smaller are all the OLD icon design)
• Windows caches all app icons in it's Icon Cache Database. When moving a new icon file to replace an Electron app's old icon it will stubbornly keep - showing the old one. The global icon cache has to be reset. Not sure when it ever updates.
• afaict, the root folder's assets\icon.png is not being used. It's the missing 1024x1024.png. (see first point above)
• only Macs require 1024x1024 for Retina displays, but .icns format, not this 860kb PNG in /assets folder.
• when we npm run start an Electron app and "pin" it to the taskbar it will revert to the default Electron icon. Unsure why.

[kustomzone]

I'm @kustomzone here btw. :)