Skip to content

Conversation

@pkratoch
Copy link
Contributor

@pkratoch pkratoch commented Nov 26, 2025

Report that the group or environment is already installed instead, or,
if the group was originally installed with a lesser reason, change its
reason.

Resolves: #1492

Tests: rpm-software-management/ci-dnf-stack#1791

This is needed for reporting the original reason for group installation
in the transaction.
Report that the group or environment is already installed instead, or,
if the group was originally installed with a lesser reason, change its
reason.

Resolves: rpm-software-management#1492
@pkratoch pkratoch requested a review from a team as a code owner November 26, 2025 18:08
@pkratoch pkratoch requested review from fhbash and removed request for a team November 26, 2025 18:08
@fhbash fhbash self-assigned this Dec 1, 2025
Copy link
Contributor

@fhbash fhbash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

before this PR:

❯ dnf group install c-development --assumeno
Updating and loading repositories:
Repositories loaded.
Package "make-1:4.4.1-11.fc43.x86_64" is already installed.
Package "gcc-15.2.1-4.fc43.x86_64" is already installed.
Package "gcc-c++-15.2.1-4.fc43.x86_64" is already installed.
Package "autoconf-2.72-7.fc43.noarch" is already installed.
Package "automake-1.18.1-2.fc43.noarch" is already installed.
Package "glibc-devel-2.42-4.fc43.x86_64" is already installed.
Package "pkgconf-2.3.0-3.fc43.x86_64" is already installed.
Package "binutils-2.45.1-1.fc43.x86_64" is already installed.
Package "bison-3.8.2-11.fc43.x86_64" is already installed.
Package "flex-2.6.4-20.fc43.x86_64" is already installed.
Package "gdb-16.3-6.fc43.x86_64" is already installed.
Package "libtool-2.5.4-7.fc43.x86_64" is already installed.
Package "strace-6.17-1.fc43.x86_64" is already installed.
Package "ctags-6.2.1-1.fc43.x86_64" is already installed.
Package "indent-2.2.13-10.fc43.x86_64" is already installed.
Package "valgrind-1:3.26.0-1.fc43.x86_64" is already installed.
Package "byacc-2.0.20240109-4.fc43.x86_64" is already installed.
Package "ccache-4.11.3-2.fc43.x86_64" is already installed.
Package "cscope-15.9-28.fc43.x86_64" is already installed.
Package "elfutils-0.194-1.fc43.x86_64" is already installed.
Package "ltrace-0.7.91-53.fc43.x86_64" is already installed.
Package "perf-6.17.8-300.fc43.x86_64" is already installed.

Package                                                                 Arch             Version                                                                  Repository                                    Size
Installing groups:
 C Development Tools and Libraries

Transaction Summary:

After this operation, 0 B extra will be used (install 0 B, remove 0 B).
Operation aborted by the user.

after:

❯ ./dnf5 group install c-development  --assumeno
Updating and loading repositories:
Repositories loaded.
Group "c-development" is already installed.
Package "make-1:4.4.1-11.fc43.x86_64" is already installed.
Package "gcc-15.2.1-4.fc43.x86_64" is already installed.
Package "gcc-c++-15.2.1-4.fc43.x86_64" is already installed.
Package "autoconf-2.72-7.fc43.noarch" is already installed.
Package "automake-1.18.1-2.fc43.noarch" is already installed.
Package "glibc-devel-2.42-4.fc43.x86_64" is already installed.
Package "pkgconf-2.3.0-3.fc43.x86_64" is already installed.
Package "binutils-2.45.1-1.fc43.x86_64" is already installed.
Package "bison-3.8.2-11.fc43.x86_64" is already installed.
Package "flex-2.6.4-20.fc43.x86_64" is already installed.
Package "gdb-16.3-6.fc43.x86_64" is already installed.
Package "libtool-2.5.4-7.fc43.x86_64" is already installed.
Package "strace-6.17-1.fc43.x86_64" is already installed.
Package "ctags-6.2.1-1.fc43.x86_64" is already installed.
Package "indent-2.2.13-10.fc43.x86_64" is already installed.
Package "valgrind-1:3.26.0-1.fc43.x86_64" is already installed.
Package "byacc-2.0.20240109-4.fc43.x86_64" is already installed.
Package "ccache-4.11.3-2.fc43.x86_64" is already installed.
Package "cscope-15.9-28.fc43.x86_64" is already installed.
Package "elfutils-0.194-1.fc43.x86_64" is already installed.
Package "ltrace-0.7.91-53.fc43.x86_64" is already installed.
Package "perf-6.17.8-300.fc43.x86_64" is already installed.

Nothing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the behavior of history when nothing is changed by group install

2 participants