No PyTorch Version in pyproject.toml

[RoyiAvital]

Hi,

How come there is no dependency on PyTorch in pyproject.toml:

skorch/pyproject.toml

Lines 19 to 25 in f7161d0

	dependencies =[
	"numpy>=1.13.3",
	"scikit-learn>=0.22.0",
	"scipy>=1.1.0",
	"tabulate>=0.7.7",
	"tqdm>=4.14.0",
	]

Also, why keep supporting such an old SciKit Learn version? Might also be useful to bump NumPy to 2.x.

[BenjaminBossan]

Regarding the lack of torch in the dependencies, it is a relic of olden times when installing PyTorch was not so easy (mostly not via pip) and we didn't want users to accidentally install a version that didn't work for them. These days, this precaution is mostly unnecessary, so I guess we can update this.

As for the min versions of scikit-klearn and numpy: Unless we know that these old versions don't work, I don't see a reason why we should bump them.

[RoyiAvital]

I see. I actually think it is a wise decision to let the user get PyTorch. I'd keep it.

Regarding SciKit Learn and NumPy, It feels too outdated even if it works.

[BenjaminBossan]

It feels too outdated even if it works.

Could you please explain why that is an issue? These are minimum versions, users can always install more recent versions. When they install skorch and these packages are missing, automatically the most recent versions will be installed. So I don't see any practical disadvantage here, but perhaps I'm missing something?