Bug: Rhino Converter throws an error when unnamed collections are filtered

[secretlyagoblin]

speckle-sharp/Objects/Converters/ConverterRhinoGh/ConverterRhinoGhShared/ConverterRhinoGh.cs

Line 740 in b67e46c

case Collection c when !c.collectionType.ToLower().Contains("model"):

If the collectionType is null in this case it silently throws and nothing in the collection loads, showing a successful pull.

should be

      case Collection c when ! (c.collectionType?.ToLower().Contains("model") ?? false):

[AlanRynne]

Hi @secretlyagoblin, thx for reporting this!

Where is the commit you're trying to receive from? (Revit, Rhino...). Could you share it with us so we could have a look?

I don't recall us changing any logic here, but I'd need to check the history to confirm.

[secretlyagoblin]

We're making our own commits via custom code, but when creating collections, collectionType defaults to null, not "". So as a result, our custom collections are causing the converter to crash.

The fix is for us to explicitly set collectionType to "" instead of null, but either way, there should be a null check here if collectionType is to remain nullable.