Handle missing processed job/resume and patch invalid job type/remote… #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… status - Add checks for missing processed_job and processed_resume in score improvement service - Patch job extraction to set default values for employmentType and remoteStatus if missing or invalid
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. WalkthroughThe changes introduce internal validation and patching of specific fields in job data extraction, ensuring required values are present and valid before model validation. Additionally, explicit error handling is added for missing processed job or resume data during scoring, providing clear error signaling in both synchronous and streaming flows. Changes
Sequence Diagram(s)sequenceDiagram
participant Agent
participant JobService
participant Validator
Agent->>JobService: Provide raw job JSON
JobService->>JobService: Patch 'location.remoteStatus' and 'employmentType'
JobService->>Validator: Validate patched JSON
Validator-->>JobService: Return validated job data
sequenceDiagram
participant ScoreService
participant DB
participant Client
ScoreService->>DB: Fetch processed job
alt Job not found
ScoreService-->>Client: Raise JobParsingError (run) / Yield error event (run_and_stream)
else Job found
ScoreService->>DB: Fetch processed resume
alt Resume not found
ScoreService-->>Client: Raise ResumeParsingError (run) / Yield error event (run_and_stream)
else Resume found
ScoreService->>Client: Continue with scoring logic
end
end
Estimated code review effort2 (~15 minutes) Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… status
Pull Request Title
Improve job extraction defaults and add error handling for processed data
Related Issue
#386
Description
This pull request addresses two issues in the backend:
It adds explicit checks for missing processed_job and processed_resume objects in the score improvement service.
It patches the job extraction logic to automatically set default values for employmentType and remoteStatus if the extracted values are missing or invalid.
Type
Proposed Changes
Screenshots / Code Snippets (if applicable)
How to Test
Checklist
Summary by CodeRabbit