Skip to content

Change DeserializeComponentRef to return error on empty input #8707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dandavison wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change DeserializeComponentRef to return error on empty input #8707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d5396
Change DeserializeComponentRef to return error on empty input
dandavison Nov 26, 2025
f968d82
errors.New
dandavison Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions chasm/ref.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package chasm

import (
"errors"
"reflect"

"go.temporal.io/api/serviceerror"
Expand Down Expand Up @@ -128,6 +129,9 @@ func (r *ComponentRef) Serialize(
// DeserializeComponentRef deserializes a byte slice into a ComponentRef.
// Provides caller the access to information including ExecutionKey, Archetype, and ShardingKey.
func DeserializeComponentRef(data []byte) (ComponentRef, error) {
if len(data) == 0 {
return ComponentRef{}, errors.New("empty chasm component ref")
Copy link

@cursor cursor bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Should use InvalidArgument instead of errors.New (Bugbot Rules)

The error returned for empty input uses errors.New instead of serviceerror.NewInvalidArgument. The PR discussion explicitly requested switching to InvalidArgument, and this matches the codebase pattern for invalid input validation as seen in path_encoder.go and visibility.go.

Fix in Cursor Fix in Web

Copy link
Member

@yycptt yycptt Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause unnecessary retries so I can't approve it.

}
var pRef persistencespb.ChasmComponentRef
if err := pRef.Unmarshal(data); err != nil {
return ComponentRef{}, err
Expand Down
5 changes: 5 additions & 0 deletions chasm/ref_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ func (s *componentRefSuite) TestShardingKey() {
}

func (s *componentRefSuite) TestSerializeDeserialize() {
_, err := DeserializeComponentRef(nil)
s.Error(err)
_, err = DeserializeComponentRef([]byte{})
s.Error(err)

executionKey := ExecutionKey{
NamespaceID: primitives.NewUUID().String(),
BusinessID: primitives.NewUUID().String(),
Expand Down
Loading