NAS-138826 / 26.04 / Add new zfs.resource.snapshot namespace #17772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Contributor
Contributor
Author
|
time 08:00 |
sonicaj
approved these changes
Dec 6, 2025
Contributor
Author
|
time 04:00 |
Contributor
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new zfs.resource.snapshot.* namespace that utilizes our new truenas_pylibzfs module. This mimics our current legacy zfs.snapshot.* namespace. The difference is that our legacy uses our process pool which makes certain operations inefficient/slow.
At first I was going to put everything into zfs.resource.* namespace but that exposed a complexity trade-off on the API/UX side that isn't worth it. Nothing uses these new endpoints but subsequent PRs will follow that converts internal callers to use. Tests have been added for each new endpoint and they all pass.