validateSnapshotLocation doesn't properly validate tilde path

[e-gineer]

Description

Non-existent tilde paths may pass validation when they shouldn't.

Severity

LOW - Input validation gap

Test Reference

Test: TestValidateSnapshotLocation_TildePath in pkg/cmdconfig/validate_test.go:290 (now failing)

Related Code

• pkg/cmdconfig/validate.go:54-84

[amentee]

@e-gineer I am a new contributor and below are my findings. The reason non-existent tilde paths pass validation is if the path contains "/" , steampipeconfig.IsPipesWorkspaceIdentifier(snapshotLocation) will always return true and nil is returned as error. Its because the path identifies itself as workspace identifier - https://github.com/turbot/pipe-fittings/blob/907ae6f34d0ce53655fe7c29dbf749aa4ae3e536/steampipeconfig/pipes_workspace.go#L31C9-L31C38

However if I remove the / from the test case and then run - the test passes.

Please suggest if I should update the logic of steampipeconfig.IsPipesWorkspaceIdentifier or I shall just remove the / from the test case.