Rust binding add prepare to transaction #4113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the query results using a struct as the rusqlite example does
NB This highlights an issue around Connection/Transaction/Prepare
Needed to add prepare to impl Transaction
It is more realistic to begin and commit the transaction outside the update function.
Moved to clearer position, improved comment.
Collaborator
|
Thanks - can you add a test or two? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly simplifies using the Rust binding (and adds a more complete example).
By adding prepare to Transaction (that just passes it onto the Transactions connection) we can write simpler application code that is passed a transaction. This allows multiple database update methods to be flexibly grouped into transactions, even when they use prepared statements.