onNodeClick should trigger a draw call after executing the user provided callback

[ricardomatias]

Is your feature request related to a problem? Please describe.
At the moment, it's not possible to simply update the way a node is drawn when it's clicked. This impacts applications which implement a node selection routine, where the graph stays exactly the same. The current solution is to switch off autoPauseRedraw which is very wasteful and rather a workaround.

Describe the solution you'd like
The library should either implicitly or explicitly call the render function after the 'onNodeClick' callback is executed.

[vasturiano]

@ricardomatias thanks for reaching out.

First of all, I assume you're referring to the 2D mode, correct?

The method onNodeClick can be used for many different reasons, like for causing events external to the graph, so it doesn't seem right to assume its outcome is a modification of the node's appearance, and forcely re-activate the render cycle.

Besides this redraw will automatically occur whenever you change the value passed to nodeColor or nodeCanvasObject so that's how you indicate to the graph that it should re-render the nodes.

If you're still having trouble with this it's better to post an online simplified example that reproduces the issue.

[ricardomatias]

@vasturiano thanks for getting back so quick.

Yes, the context is a 2D graph.

The code is open source, so I'll just reference it here for the sake of making things clear:

• CCMap - React wrapper for the Graph
• CCMapController - External class managing the graph

We have a class property which changes whenever there's a new node selected. We want that the selected node is rendered differently, which happens within nodeCanvasObject. We tried triggering an update to the CCMap react component whenever the selectedNodeId changed, but the whole graph force engine got retriggered and the graph was laid out anew (even when the graphData didn't change (I verified this)).

I understand that implicitly re-rendering it might cause new problems in certain scenarios. But I think it would make sense to be able to call it explicitly by passing a true boolean at the end of the onNodeClick callback (f.ex). The data doesn't really change in our use case, just the view.

We also want to add a light/dark theme switcher at a certain point which also seems like not possible without retriggering a complete layout rerendering.

[vasturiano]

@ricardomatias please provide a simple example on https://codesandbox.io/. Otherwise it's too difficult to isolate the issue in your app, or quickly verify if a code change is effective.