fix(cava): dispatch GTK operations to main thread #4679
+24
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cava backend emits signals from a worker thread, but GTK widget operations must run on the main thread. This causes intermittent SIGSEGV/SIGABRT crashes with stack traces through pixman_region32_union and gtk_label_set_markup. Wrap all GTK operations in onUpdate() and onSilence() with Glib::signal_idle().connect_once() to safely dispatch them to the main thread. Additional improvements: - Cache style context to avoid repeated get_style_context() calls - Check has_class() before removing classes to avoid unnecessary ops - Use early return pattern in onSilence() for clarity - Use cached format_silent_ instead of re-reading config
Contributor
|
@BurgessTG , why do you do the same work? See PR #4587 |
Author
|
Tbh, I was adding cava and was experiencing crashes on my own behalf. Instead of looking for a fix or checking I found one pretty quick. Wanted to offer it out as different option 😄 |
Contributor
|
@BurgessTG, thank you. I didn't realize in my PR with some enhancements dispatching was a part of backend.. where basically it should be the logic of the frontend. Original PR is fixed for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cava backend emits signals from a worker thread, but GTK widget
operations must run on the main thread. This causes intermittent
SIGSEGV/SIGABRT crashes with stack traces through pixman_region32_union
and gtk_label_set_markup.
This wraps all GTK operations in
onUpdate()andonSilence()withGlib::signal_idle().connect_once()to safely dispatch them to themain thread.
Additional improvements:
get_style_context()callshas_class()before removing classesonSilence()format_silent_instead of re-reading configTested on Arch Linux with 15fps cava visualization - stable with no crashes.