-
Notifications
You must be signed in to change notification settings - Fork 514
feat: Update api versions and add resource derived types for virtual hub #6242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@oZakari - Looks like there is a problem with the max test changes you made. |
|
Hey @arnoldna, I think there is actually an issue with the original module or the RP itself. If you try to deploy the module as it is today with hubRoutingPreference it will fail at least in the two tenants I owned. I was hoping it was just an outdated API version, but think it's beyond that. Have you tried setting that property in your environment? |
|
@oZakari - let me take a look at the deployment issue. |
|
@oZakari - I was able to take the main branch from your repo and was able to deploy without error. both the max and the routing intent tests. I will switch to your branch and will try deploying with your changes. |
- Updated the API version for the virtual hub resource from 2024-10-01 to 2025-01-01. - This change ensures compatibility with the latest features and improvements in the Azure API.
Description
This pull request updates the Azure Virtual Hub module and its related resources to use the latest API version (2025-01-01) and introduces support for additional resource derived types. The changes ensure improved compatibility with new Azure features and future-proof the module. Parameter definitions and documentation have also been updated to reflect these changes, including the removal of hardcoded allowed values in favor of resource-derived types.
API Version Updates
Microsoft.Network/virtualHubs,hubRouteTables,hubVirtualNetworkConnections, and related resources to use API version2025-01-01in Bicep, JSON, and documentation files. [1] [2] [3] [4] [5] [6] [7]Resource Derived Types
tags,hubRoutingPreference,preferredRoutingGateway, andvirtualRouterAsnto use resource-derived types based on the latest API version, improving flexibility and maintainability. [1] [2] [3] [4] [5] [6]Documentation and Example Updates
preferredRoutingGateway,routingIntent,virtualRouterAsn) and the API version change. [1] [2] [3] [4]Changelog
Miscellaneous
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.