Skip to content

Conversation

@oZakari
Copy link
Contributor

@oZakari oZakari commented Nov 20, 2025

Description

This pull request updates the Azure Virtual Hub module and its related resources to use the latest API version (2025-01-01) and introduces support for additional resource derived types. The changes ensure improved compatibility with new Azure features and future-proof the module. Parameter definitions and documentation have also been updated to reflect these changes, including the removal of hardcoded allowed values in favor of resource-derived types.

API Version Updates

  • Updated all references to Microsoft.Network/virtualHubs, hubRouteTables, hubVirtualNetworkConnections, and related resources to use API version 2025-01-01 in Bicep, JSON, and documentation files. [1] [2] [3] [4] [5] [6] [7]

Resource Derived Types

  • Changed parameter definitions for tags, hubRoutingPreference, preferredRoutingGateway, and virtualRouterAsn to use resource-derived types based on the latest API version, improving flexibility and maintainability. [1] [2] [3] [4] [5] [6]

Documentation and Example Updates

  • Updated the README documentation and usage examples to reflect new parameters (preferredRoutingGateway, routingIntent, virtualRouterAsn) and the API version change. [1] [2] [3] [4]
  • Removed hardcoded allowed values for parameters in documentation, relying on resource-derived types instead. [1] [2]

Changelog

  • Added a changelog entry for version 0.4.3, summarizing the API version update and addition of resource derived types.

Miscellaneous

  • Minor text correction in the privacy statement in the README.

Pipeline Reference

Pipeline
avm.res.network.virtual-hub

Type of Change

  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation
  • Update to CI Environment or utilities (Non-module affecting changes)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I have updated the module's CHANGELOG.md file with an entry for the next version

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Nov 20, 2025
@oZakari oZakari marked this pull request as ready for review November 20, 2025 03:01
@oZakari oZakari requested review from a team as code owners November 20, 2025 03:01
@avm-organizer avm-organizer bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Nov 20, 2025
@avm-organizer avm-organizer bot requested a review from arnoldna November 20, 2025 03:01
@arnoldna
Copy link
Contributor

@oZakari - Looks like there is a problem with the max test changes you made.

@oZakari
Copy link
Contributor Author

oZakari commented Nov 20, 2025

Hey @arnoldna, I think there is actually an issue with the original module or the RP itself. If you try to deploy the module as it is today with hubRoutingPreference it will fail at least in the two tenants I owned. I was hoping it was just an outdated API version, but think it's beyond that. Have you tried setting that property in your environment?

@arnoldna
Copy link
Contributor

@oZakari - let me take a look at the deployment issue.

@arnoldna
Copy link
Contributor

@oZakari - I was able to take the main branch from your repo and was able to deploy without error. both the max and the routing intent tests. I will switch to your branch and will try deploying with your changes.

oZakari and others added 5 commits November 21, 2025 11:46
- Updated the API version for the virtual hub resource from 2024-10-01 to 2025-01-01.
- This change ensures compatibility with the latest features and improvements in the Azure API.
@oZakari oZakari enabled auto-merge (squash) November 24, 2025 18:12
@oZakari oZakari merged commit efc3dbb into Azure:main Nov 24, 2025
4 checks passed
@oZakari oZakari deleted the update-vhub branch November 24, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants