Skip to content

fix: Update deployment name composition #6314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtracey93 merged 5 commits into from
Dec 6, 2025
Merged

fix: Update deployment name composition #6314

jtracey93 merged 5 commits into from
Dec 6, 2025
+69 −49

Conversation

@jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Dec 6, 2025 •
edited
Loading

Description

Pipeline Reference

Pipeline
avm.ptn.authorization.role-assignment
avm.ptn.authorization.policy-assignment

Type of Change

  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation
  • Update to CI Environment or utilities (Non-module affecting changes)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I have updated the module's CHANGELOG.md file with an entry for the next version

@jtracey93
AVM-PTN: Update deployment name usage for performance
6f69402 
- Removed usage of `deployment().name` in module names to enhance performance during redeploys and when used in deployment stacks.
- Updated module names to use `managementGroup().name` and other parameters for uniqueness.
- No functional changes to the module.
@jtracey93 jtracey93 requested review from a team as code owners December 6, 2025 05:58
@avm-organizer avm-organizer bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Dec 6, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 6, 2025
@jtracey93
AVM-PTN: Update deployment name usage for policy assignments
dbdaa32 
- Refactor deployment names for subscription and resource group policy assignments to include management group name for uniqueness.
- Ensure compliance with naming conventions and improve clarity in deployment identifiers.
- Module path: avm/ptn/authorization/policy-assignment
@jtracey93
AVM-PTN: Update deployment name usage for role assignments
4b58485 
- Refactored deployment name generation to eliminate usage of `deployment().name` for improved performance and reduced deployment count.
- Updated module names in main.bicep and main.json for management group, subscription, and resource group role assignments.
- No functional changes to the module.
@jtracey93 jtracey93 requested a review from a team as a code owner December 6, 2025 07:55
@jtracey93
AVM-PTN: Update serviceShort parameter values
f11f567 
- Updated serviceShort parameter values in multiple test files to ensure uniqueness and avoid conflicts.
- Affected files include role assignments for management group, resource group, and subscription scopes.
@jtracey93
AVM-PTN: Update serviceShort parameter values
bcf31d0 
- Corrected serviceShort parameter values in multiple test files for role assignment.
- Ensured consistency in naming conventions across management group, resource group, and subscription scopes.
- Updated files: mg.defaults, mg.max, rg.default, rg.max, sub.default, sub.max.
@jtracey93 jtracey93 enabled auto-merge (squash) December 6, 2025 08:21
@jtracey93 jtracey93 merged commit f8d4f63 into main Dec 6, 2025
25 checks passed
@jtracey93 jtracey93 deleted the users/jtracey93/fix/deployment-name-usage-for-alz branch December 6, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@jaredfholgate jaredfholgate jaredfholgate approved these changes

Assignees

No one assigned

Labels

Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jtracey93 @jaredfholgate @AlexanderSehr