Skip to content

Conversation

@jkomyno
Copy link
Collaborator

@jkomyno jkomyno commented Nov 20, 2025

This PR:

  • fixes the composio.tools.get(user_id=user_id, toolkits=["GMAIL"]) command used in https://docs.composio.dev/docs/quickstart, so that the GMAIL_FETCH_EMAILS tool is retrieved
  • sets important=True to calls to self._client.tools.list

Note

Passes important="true" when listing tools to filter to important tools in both slug and toolkit/search paths.

  • Python core:
    • In python/composio/core/models/tools.py, get_raw_composio_tools now passes important="true" to self._client.tools.list for both slug-based and toolkit/search queries, filtering to important tools.

Written by Cursor Bugbot for commit b1abbeb. This will update automatically on new commits. Configure here.

@jkomyno jkomyno marked this pull request as ready for review November 20, 2025 09:04
@jkomyno jkomyno requested a review from haxzie as a code owner November 20, 2025 09:04
self._client.tools.list(
tool_slugs=",".join(tools),
toolkit_versions=none_to_omit(self._toolkit_versions),
important=True,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Filtering important tools excludes explicitly requested tools

When users explicitly request specific tools by slug, the important=True filter could exclude tools that weren't marked as important but were explicitly requested. This violates the principle that explicit requests should always be honored. The filter should only apply to toolkit-based and search-based queries, not slug-based queries where the user has explicitly named the tools they need.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants