Skip to content

Fix CSS selector support for numeric IDs and escape sequences #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sinpru wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix CSS selector support for numeric IDs and escape sequences #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d4c7cc
Fix CSS selector support for numeric IDs and escape sequences
sinpru Nov 13, 2025
f83d28a
Fix CSS selector regex
sinpru Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 61 additions & 1 deletion src/FlaUI.WebDriver/Controllers/FindElementsController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ private async Task<ActionResult> FindElementFrom(Func<AutomationElement> startNo
{
element = await Wait.Until(() => startNode().FindFirstByXPath(findElementRequest.Value), element => element != null, session.ImplicitWaitTimeout);
}
else if (findElementRequest.Using == "css selector")
{
var (strategy, value) = ParseCssSelector(findElementRequest.Value);
var condition = _conditionParser.ParseCondition(session.Automation.ConditionFactory, strategy, value);
element = await Wait.Until(() => startNode().FindFirstDescendant(condition), element => element != null, session.ImplicitWaitTimeout);
}
else
{
var condition = _conditionParser.ParseCondition(session.Automation.ConditionFactory, findElementRequest.Using, findElementRequest.Value);
Expand All @@ -71,7 +77,7 @@ private async Task<ActionResult> FindElementFrom(Func<AutomationElement> startNo
return NoSuchElement(findElementRequest);
}

var knownElement = session.GetOrAddKnownElement(element);
var knownElement = session.GetOrAddKnownElement(element);
return await Task.FromResult(WebDriverResult.Success(new FindElementResponse
{
ElementReference = knownElement.ElementReference,
Expand All @@ -85,6 +91,12 @@ private async Task<ActionResult> FindElementsFrom(Func<AutomationElement> startN
{
elements = await Wait.Until(() => startNode().FindAllByXPath(findElementRequest.Value), elements => elements.Length > 0, session.ImplicitWaitTimeout);
}
else if (findElementRequest.Using == "css selector")
{
var (strategy, value) = ParseCssSelector(findElementRequest.Value);
var condition = _conditionParser.ParseCondition(session.Automation.ConditionFactory, strategy, value);
elements = await Wait.Until(() => startNode().FindAllDescendants(condition), elements => elements.Length > 0, session.ImplicitWaitTimeout);
}
else
{
var condition = _conditionParser.ParseCondition(session.Automation.ConditionFactory, findElementRequest.Using, findElementRequest.Value);
Expand Down Expand Up @@ -140,5 +152,53 @@ private Session GetSession(string sessionId)
session.SetLastCommandTimeToNow();
return session;
}

private (string strategy, string value) ParseCssSelector(string cssSelector)
{
var nameMatch = Regex.Match(cssSelector, @"^\*?\[name\s*=\s*""(.+?)""\]$", RegexOptions.IgnoreCase);
if (nameMatch.Success)
{
return ("name", UnescapeCssValue(nameMatch.Groups[1].Value));
}

var idMatch = Regex.Match(cssSelector, @"^#((?:[\w-]|\\[0-9a-fA-F]{1,6}\s?)+)$");
if (idMatch.Success)
{
return ("id", UnescapeCssValue(idMatch.Groups[1].Value));
}

var classMatch = Regex.Match(cssSelector, @"^\.((?:[\w-]|\\[0-9a-fA-F]{1,6}\s?)+)$");
if (classMatch.Success)
{
return ("class name", UnescapeCssValue(classMatch.Groups[1].Value));
}

var idAttrMatch = Regex.Match(cssSelector, @"^\*?\[id\s*=\s*""(.+?)""\]$", RegexOptions.IgnoreCase);
if (idAttrMatch.Success)
{
return ("id", UnescapeCssValue(idAttrMatch.Groups[1].Value));
}

var classAttrMatch = Regex.Match(cssSelector, @"^\*?\[class\s*=\s*""(.+?)""\]$", RegexOptions.IgnoreCase);
if (classAttrMatch.Success)
{
return ("class name", UnescapeCssValue(classAttrMatch.Groups[1].Value));
}

throw WebDriverResponseException.UnsupportedOperation(
$"CSS selector '{cssSelector}' is not supported. Only simple selectors are allowed: " +
"#id, .className, [name=\"value\"], [id=\"value\"], [class=\"value\"]"
);
}

private string UnescapeCssValue(string cssValue)
{
var result = Regex.Replace(cssValue, @"\\([0-9a-fA-F]{1,6})\s?", m =>
((char)Convert.ToInt32(m.Groups[1].Value, 16)).ToString());

result = Regex.Replace(result, @"\\(.)", "$1");

return result;
}
}
}
1 change: 1 addition & 0 deletions src/FlaUI.WebDriver/Services/ConditionParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public PropertyCondition ParseCondition(ConditionFactory conditionFactory, strin
{
switch (@using)
{
case "id":
case "accessibility id":
return conditionFactory.ByAutomationId(value);
case "name":
Expand Down
Loading