-
Notifications
You must be signed in to change notification settings - Fork 60
feat: add aap_environment field to support AAP compatibility #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to make this executable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to make this executable
Sispheor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just set back the rights on files and we're good. Thx for the PR !
|
Tests need an update + you have to sign your commits. |
ffd7f92 to
4afbe74
Compare
|
Oh yes the pyproject is in conflict because I changed the target branch. We push everything in dev. |
6592cf5 to
dce14af
Compare
|
Sorry for the confusion. I ran into some restrictions and also made a few mistakes, but it should be fine now ? |
|
Github is still complaining about a conflict but I don't see where it is. |
|
Tell me, how can I help? |
Signed-off-by: Lilian Montes <[email protected]>
Signed-off-by: Montes-L <[email protected]> Fix pyproject.toml and poetry.lock Signed-off-by: Montes-L <[email protected]>
dce14af to
3d1214f
Compare
|
I fixed your branch. a rebase was needed to be on top of dev. |
|
Merged. thx |
|
Thanks for your help ! |
This PR introduces the
aap_environmentfield in the Tower server configuration.Changes include:
aap_environmentfield in the TowerServer model(/service_catalog/models/tower_server.py)
(/service_catalog/forms/tower_server_forms.py)
(/service_catalog/migrations/0047_towerserver_aap_environment.py)
(/templates/service_catalog/towerserver_detail.html)
This update allows Squest to support AAP environments.
Closes #811
Sorry for the delay, resuming work on this feature