Skip to content

Conversation

@Montes-L
Copy link

This PR introduces the aap_environment field in the Tower server configuration.

Changes include:

  • Added aap_environment field in the TowerServer model
    (/service_catalog/models/tower_server.py)
  • Updated forms to handle the new field
    (/service_catalog/forms/tower_server_forms.py)
  • Created database migration
    (/service_catalog/migrations/0047_towerserver_aap_environment.py)
  • Updated template to display the new field
    (/templates/service_catalog/towerserver_detail.html)

This update allows Squest to support AAP environments.
Closes #811

Sorry for the delay, resuming work on this feature

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to make this executable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to make this executable

Copy link
Contributor

@Sispheor Sispheor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just set back the rights on files and we're good. Thx for the PR !

@Sispheor
Copy link
Contributor

Tests need an update + you have to sign your commits.
Sorry it's now mandatory...

@Montes-L Montes-L force-pushed the dev-aap-compatible branch 2 times, most recently from ffd7f92 to 4afbe74 Compare September 19, 2025 13:33
@Sispheor Sispheor changed the base branch from master to dev September 19, 2025 13:54
@Sispheor
Copy link
Contributor

Oh yes the pyproject is in conflict because I changed the target branch. We push everything in dev.
Only the bump of towerlib should be required in this file.

@Montes-L
Copy link
Author

Sorry for the confusion. I ran into some restrictions and also made a few mistakes, but it should be fine now ?

@Sispheor
Copy link
Contributor

Github is still complaining about a conflict but I don't see where it is.

@Montes-L
Copy link
Author

Tell me, how can I help?

Signed-off-by: Montes-L <[email protected]>

Fix pyproject.toml and poetry.lock

Signed-off-by: Montes-L <[email protected]>
@Sispheor
Copy link
Contributor

I fixed your branch. a rebase was needed to be on top of dev.

@Sispheor Sispheor merged commit 83fdb6e into HewlettPackard:dev Sep 19, 2025
1 check failed
@Sispheor
Copy link
Contributor

Merged. thx

@Montes-L
Copy link
Author

Thanks for your help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AAP 2.5 (containerized) – Issue with the new API endpoint

2 participants