build(deps): EXPOSED-919 Bump test SQL Server to 2025 (17.x) #2677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also switch docker image to no longer use Azure SQL Edge
bog-walk
commented
Dec 2, 2025
| container_name: SQLServer | ||
| restart: always | ||
| image: mcr.microsoft.com/azure-sql-edge:2.0.0 | ||
| image: mcr.microsoft.com/mssql/server:2025-RC1-ubuntu-24.04 |
Member
Author
There was a problem hiding this comment.
I wasn't planning to change this, but then I was looking into the underlying database & came across this announcement.
@obabichevjb Please checkout & try this new image locally to make sure it works well for you too.
Collaborator
There was a problem hiding this comment.
Checked, it works for me locally. All the tests passed for SQL Server on the new image.
bog-walk
commented
Dec 2, 2025
| SQLSERVER( | ||
| { | ||
| "jdbc:sqlserver://127.0.0.1:3005" | ||
| "jdbc:sqlserver://127.0.0.1:3005;encrypt=false;" |
Member
Author
There was a problem hiding this comment.
Prior to mssql-jdbc version 10.x, this value was set to false by default. After version 10.x, it became true.
If left true, it would cause all tests to fail. Since we weren't encrypting before, I didn't see any reason to start now?
bog-walk
commented
Dec 2, 2025
Comment on lines
-51
to
+54
| if (dbProductName.startsWith("Microsoft Azure SQL ")) { | ||
| if ( | ||
| dbProductName.startsWith("Microsoft Azure SQL ") || | ||
| dbProductName.startsWith("Microsoft SQL Server ") | ||
| ) { |
obabichevjb
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
mssql-jdbcto 13.2.1.jre11.Detailed description:
Why:
mssql-jdbcis long overdue.How: The driver version bump required setting a previously default value explicitly -->
encrypt=false;Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-919