build(deps): Bump MariaDB Connector/J from 3.3.1 to 3.5.6 & drop 2.x from tests #2687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unify all MariaDB tests to use latest 3.x driver
bog-walk
commented
Dec 8, 2025
Comment on lines
-116
to
+117
| if (testDb in TestDB.ALL_MYSQL) { | ||
| // Query execution was interrupted, max statement execution time exceeded | ||
| expectException<ExposedR2dbcException> { | ||
| queryWithHint.single() | ||
| } | ||
| } else { | ||
| // MariaDB has much fewer optimizer hint options and, like any other db, will just ignore the comment | ||
| expect(0) { | ||
| queryWithHint.single()[sleepNSeconds] | ||
| } | ||
| // Query execution was interrupted, max statement execution time exceeded | ||
| expectException<ExposedR2dbcException> { | ||
| queryWithHint.single() |
Member
Author
There was a problem hiding this comment.
MariaDB server 12.x came with expanded optimizer hint support, like the use of MAX_EXECUTION_TIME in this test.
obabichevjb
approved these changes
Dec 9, 2025
| } | ||
|
|
||
| withTables(excludeSettings = TestDB.ALL_MARIADB + TestDB.MYSQL_V5, testTable) { testDb -> | ||
| withTables(excludeSettings = setOf(TestDB.MARIADB, TestDB.MYSQL_V5), testTable) { testDb -> |
Collaborator
There was a problem hiding this comment.
It might be good to keep ALL_MARIADB and replace all the usages of MARIADB with ALL_MARIADB. It would be easier to add next version if happens one day. But I don't expect it in the nearest future so it's completely not critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
MARIADB_V2(which used last driver version 2.x)Detailed description:
Why: These are the latest driver and server versions for MariaDB.
Why Drop MariaDB 2.x from tests:
To be honest, I'm not sure why we were testing the 2 drivers (on the same server version) when it was documented that 3.x would be fully backwards compatible with 2.7. There was also no distinction in a single test between
V2versusV3(unlike with MySQL 5 vs 8). So we have no example of a single case where the 3.x driver would pass while the 2.x driver would fail.It is also documented that driver 2.7 would stop getting maintenance releases after 3.x became stable, which was in 2022.
Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist