More axpby methods for Diagonals

[kshyatt]

These dispatch to bad places in LinearAlgebra.jl otherwise

[github-actions]

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.

diff --git a/src/host/linalg.jl b/src/host/linalg.jl
index bc59996..e17d08d 100644
--- a/src/host/linalg.jl
+++ b/src/host/linalg.jl
@@ -309,11 +309,13 @@ function LinearAlgebra.mul!(C::Diagonal{<:Any, <:AbstractGPUArray},
     return C
 end
 
-function LinearAlgebra.mul!(C::Diagonal{<:Any, <:AbstractGPUArray},
-                            A::Diagonal{<:Any, <:AbstractGPUArray},
-                            B::Diagonal{<:Any, <:AbstractGPUArray},
-                            α::Number,
-                            β::Number)
+function LinearAlgebra.mul!(
+        C::Diagonal{<:Any, <:AbstractGPUArray},
+        A::Diagonal{<:Any, <:AbstractGPUArray},
+        B::Diagonal{<:Any, <:AbstractGPUArray},
+        α::Number,
+        β::Number
+    )
     dc = C.diag
     da = A.diag
     db = B.diag
@@ -339,14 +341,16 @@ function LinearAlgebra.mul!(C::Diagonal{<:Any, <:AbstractGPUArray},
     return C
 end
 
-function LinearAlgebra.mul!(C::Diagonal{<:Any, <:AbstractGPUArray},
-                            A::Union{AbstractGPUArray, Adjoint{T,<:AbstractGPUArray{T}}, Transpose{T,<:AbstractGPUArray{T}}},
-                            B::Union{AbstractGPUArray, Adjoint{T,<:AbstractGPUArray{T}}, Transpose{T,<:AbstractGPUArray{T}}},
-                            α::Number,
-                            β::Number) where {T}
+function LinearAlgebra.mul!(
+        C::Diagonal{<:Any, <:AbstractGPUArray},
+        A::Union{AbstractGPUArray, Adjoint{T, <:AbstractGPUArray{T}}, Transpose{T, <:AbstractGPUArray{T}}},
+        B::Union{AbstractGPUArray, Adjoint{T, <:AbstractGPUArray{T}}, Transpose{T, <:AbstractGPUArray{T}}},
+        α::Number,
+        β::Number
+    ) where {T}
     dc = C.diag
-    d  = length(dc)
-    m, n   = size(A, 1), size(A, 2)
+    d = length(dc)
+    m, n = size(A, 1), size(A, 2)
     m′, n′ = size(B, 1), size(B, 2)
     m == d  || throw(DimensionMismatch("left hand side has $m rows but output is $d by $d"))
     n′ == d || throw(DimensionMismatch("right hand side has $n′ cols but output is $d by $d"))
@@ -386,8 +390,9 @@ function LinearAlgebra.mul!(B::AbstractGPUVecOrMat,
 end
 
 function LinearAlgebra.mul!(B::AbstractGPUVecOrMat,
-                            A::Union{AbstractGPUArray, Adjoint{T,<:AbstractGPUArray{T}}, Transpose{T,<:AbstractGPUArray{T}}},
-                            D::Diagonal{<:Any, <:AbstractGPUArray}) where {T}
+        A::Union{AbstractGPUArray, Adjoint{T, <:AbstractGPUArray{T}}, Transpose{T, <:AbstractGPUArray{T}}},
+        D::Diagonal{<:Any, <:AbstractGPUArray}
+    ) where {T}
     dd = D.diag
     d = length(dd)
     m, n = size(A, 1), size(A, 2)
@@ -401,10 +406,11 @@ function LinearAlgebra.mul!(B::AbstractGPUVecOrMat,
 end
 
 function LinearAlgebra.mul!(B::AbstractGPUVecOrMat,
-                            A::Union{AbstractGPUArray, Adjoint{T,<:AbstractGPUArray{T}}, Transpose{T,<:AbstractGPUArray{T}}},
+        A::Union{AbstractGPUArray, Adjoint{T, <:AbstractGPUArray{T}}, Transpose{T, <:AbstractGPUArray{T}}},
                             D::Diagonal{<:Any, <:AbstractGPUArray},
                             α::Number,
-                            β::Number) where {T}
+        β::Number
+    ) where {T}
     dd = D.diag
     d = length(dd)
     m, n = size(A, 1), size(A, 2)

[christiangnrd]

@kshyatt Can I push test fixes?

[kshyatt]

Go for it

…

On Thu, Dec 4, 2025 at 3:24 PM Christian Guinard ***@***.***> wrote: *christiangnrd* left a comment (JuliaGPU/GPUArrays.jl#665) <#665 (comment)> @kshyatt <https://github.com/kshyatt> Can I push test fixes? — Reply to this email directly, view it on GitHub <#665 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKJY7ZK3QX5M4TYGRJJAD4AA7ZTAVCNFSM6AAAAACN2NJJM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMJSGUYDSOJZGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kshyatt]

Good to merge? Huge shoutout to @christiangnrd for getting this in shape