Support computedomain for multi-node NIMServices #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
varunrsekar
commented
Nov 6, 2025
varunrsekar
commented
- TODO: Resolve NVIDIA/k8s-dra-driver-gpu dependency
- TODO: Resolve kserve not supporting k8s.io/* dependency version > v1.33
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
shivamerla
reviewed
Nov 6, 2025
| annotations: | ||
| {{- .Annotations | yaml | nindent 4 }} | ||
| {{- end }} | ||
| spec: |
Collaborator
There was a problem hiding this comment.
extra indentation here for the spec field.
shivamerla
reviewed
Nov 6, 2025
| MPIStartTimeout int `json:"mpiStartTimeout"` | ||
| } | ||
|
|
||
| type NIMServiceComputeDomainSpec struct{} |
Collaborator
There was a problem hiding this comment.
as discussed, we need to handle case of pre-existing CD as well
type NIMServiceComputeDomainSpec struct {
Create *bool `json:"create,omitempty"`
Name string `json:"name,omitempty"`
}
| MPIStartTimeout int `json:"mpiStartTimeout"` | ||
| } | ||
|
|
||
| type NIMServiceComputeDomainSpec struct{} |
Collaborator
There was a problem hiding this comment.
Should be called ComputeDomainSpec
| if n.Spec.MultiNode != nil && n.Spec.MultiNode.Parallelism != nil && n.Spec.MultiNode.Parallelism.Tensor != nil { | ||
| return *n.Spec.MultiNode.Parallelism.Pipeline | ||
| } | ||
| return 0 |
Collaborator
There was a problem hiding this comment.
No part of your change, but can you please update it?
GetMultiNodePipelineParallelism() is looking for n.Spec.MultiNode.Parallelism.Tensornil check instead of n.Spec.MultiNode.Parallelism.Pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.