fix tapping messages, fix pressandhold/doubletap on touch #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
first commit works, I should probably also test the second one |
Member
|
can you rebase this on master? |
Contributor
Author
|
like that? |
Member
|
mhm, no, differently :D You rebased master on your commit instead >.< |
deepbluev7
force-pushed
the
fix_tapping_timeline
branch
from
f7d6ad5 to
24970b8
Compare
Member
|
(fixed it) |
Member
|
Have you tested it now? |
deepbluev7
reviewed
Apr 2, 2022
| id: row | ||
|
|
||
| property var model | ||
| property int buttonSize: Settings.mobileMode? 22 : 16 |
Member
There was a problem hiding this comment.
before they should have been implicitly dependent on whatever is bigger, font size or button size. Can you maybe make this Math.max(fontMetrics.lineHeight, 16) * 1.5 or so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just wait for me to test this on my phone