Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Oct 13, 2025

Overview

fix whitescreen issue when clicking an adapter

display_adapter.mov

close RQA-4749

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

fix whitescreen issue when clicking an adapter

close RQA-4749
@koji koji requested review from jerader and ncdiehl11 October 13, 2025 22:23
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.18%. Comparing base (8537004) to head (b64e4b7).
⚠️ Report is 3 commits behind head on chore_release-pd-8.6.0.

Files with missing lines Patch % Lines
...src/components/organisms/SlotDetailModal/index.tsx 0.00% 35 Missing ⚠️
...igner/DeckSetup/Overlays/ActiveLabwareControls.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.6.0   #19787      +/-   ##
==========================================================
- Coverage                   26.18%   26.18%   -0.01%     
==========================================================
  Files                        3420     3420              
  Lines                      286299   286307       +8     
  Branches                    32721    32721              
==========================================================
  Hits                        74963    74963              
- Misses                     211314   211322       +8     
  Partials                       22       22              
Flag Coverage Δ
protocol-designer 18.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...igner/DeckSetup/Overlays/ActiveLabwareControls.tsx 2.59% <0.00%> (+0.06%) ⬆️
...src/components/organisms/SlotDetailModal/index.tsx 1.16% <0.00%> (-0.08%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji marked this pull request as ready for review October 14, 2025 00:00
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koji koji merged commit ff358c6 into chore_release-pd-8.6.0 Oct 14, 2025
21 of 22 checks passed
@koji koji deleted the fix_RQA-4749-adapter-display branch October 14, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants