Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Dec 5, 2025

Overview

focus state is causing unexpected background color change. this pr fixes that issue.

before

button_focus.mov

after

primarybutton.mov

close AUTH-

Test Plan and Hands on Testing

Changelog

List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes.

Review requests

  • What do you need from reviewers to feel confident this PR is ready to merge?
  • Ask questions.

Risk assessment

low

koji added 2 commits December 5, 2025 17:48
focus state is causing unexpected background color change. this pr fixes that issue.

close AUTH-
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.06%. Comparing base (a102faf) to head (34d9a6b).
⚠️ Report is 3 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #20306       +/-   ##
===========================================
+ Coverage   25.83%   57.06%   +31.23%     
===========================================
  Files        3627     3627               
  Lines      302041   302147      +106     
  Branches    42320    42593      +273     
===========================================
+ Hits        78020   172429    +94409     
+ Misses     223992   129490    -94502     
- Partials       29      228      +199     
Flag Coverage Δ
app 46.22% <ø> (+45.06%) ⬆️
protocol-designer 19.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
components/src/atoms/buttons/PrimaryButton.tsx 100.00% <ø> (ø)

... and 1845 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji closed this Dec 6, 2025
@koji koji deleted the fix_button-focus-issue branch December 6, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants