CHAD-17066: zigbee-dimmer-remote lazy loading subdrivers #2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 71 files 477 suites 0s ⏱️ Results for commit 3b8ea33. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3b8ea33 |
cjswedes
approved these changes
Dec 11, 2025
Contributor
cjswedes
left a comment
cjswedes
left a comment
There was a problem hiding this comment.
LGTM besides the health_check field being removed
| capabilities.battery, | ||
| capabilities.button, | ||
| capabilities.switch, | ||
| capabilities.switchLevel |
Contributor
There was a problem hiding this comment.
nit: maybe fix the extra spaces when we move from tabs to spaces
| init = device_init, | ||
| }, | ||
| sub_drivers = { require("zigbee-accessory-dimmer"), require("zigbee-battery-accessory-dimmer")}, | ||
| health_check = false, |
Contributor
There was a problem hiding this comment.
This should remain! Please check the other PRs for this, looks like it was a problem with the script if this line was right next to the health check line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy loading of
zigbee-dimmer-remotesub-drivers and copyright updates.