Skip to content

Conversation

@alandtse
Copy link
Owner

@alandtse alandtse commented Dec 7, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 7, 2025 03:07
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • vr
  • ng

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alandtse alandtse merged commit 304b9a0 into master Dec 7, 2025
24 of 28 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This is a maintenance release (2025-12-06) that primarily updates the alexapy dependency from version 1.29.9 to 1.29.12, along with several minor bug fixes and improvements. The PR ensures consistency across configuration files, tests, and documentation while addressing issues related to air quality sensor device class mappings and error message formatting.

  • Dependency update: alexapy library upgraded from 1.29.9 to 1.29.12 across all relevant files
  • Bug fix: Air quality sensor device class mapping corrected for VolatileOrganicCompounds (changed from "volatile_organic_compounds" to "aqi")
  • Code improvements: Enhanced log messages and exception handling comments for better clarity

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Updated alexapy dependency version to 1.29.12
poetry.lock Regenerated lock file with new alexapy version hashes and updated content-hash
custom_components/alexa_media/manifest.json Updated alexapy requirement to match pyproject.toml
custom_components/alexa_media/const.py Fixed device class mapping for VolatileOrganicCompounds from "volatile_organic_compounds" to "aqi"
tests/test_const.py Updated test expectations to match the corrected device class mapping
custom_components/alexa_media/strings.json Simplified 2fa_key_invalid error message by removing unused {message} placeholder
custom_components/alexa_media/init.py Improved log message clarity ("retries" → "attempts") and added explanatory comment for expected CancelledError
custom_components/alexa_media/alexa_entity.py Added smart_switch type to AlexaEntities TypedDict to match existing usage
.github/copilot-instructions.md Updated documentation to reflect new alexapy version in dependency examples

"oauth_error": "Could not complete OAuth login. Please try again.",
"invalid_url": "URL is invalid: {message}",
"2fa_key_invalid": "{otp_secret} is invalid.\n{message}",
"2fa_key_invalid": "{otp_secret} is invalid",
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message format was simplified by removing the {message} placeholder, but the corresponding translation file custom_components/alexa_media/translations/en.json still contains the old format with {message} on line 9. This inconsistency should be resolved by updating en.json to match: "2fa_key_invalid": "{otp_secret} is invalid".

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants