Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA
subscribe method sits at the place where deadlock issue is initiated. We would be making the subscribe function independent from the broadcast server, eliminating the possibility of deadlock caused by the addListener channel. By directly adding the listner into the list. This would aviod the deadlock issue where the server is bussy with other operation and new listerner waiting to be pushed inside the listener list and server is waiting for the listener to be added.
fix and improvement
broadcastServer. We Directly append the new listener to the listeners slice inside theSubscribemethod. Making the code easier to understand and maintain. Directly appending to the listeners slice avoids the overhead of using an additional channel.