Skip to content

fix(form): export SubmitterProps type #9302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leshalv wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(form): export SubmitterProps type #9302

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ee21a2
fix(layout): prevent mobile menu drawer auto-collapsing on open
Oct 26, 2025
a646ed1
Merge remote-tracking branch 'origin/master'
Nov 24, 2025
428c060
fix(form): export SubmitterProps type
Nov 24, 2025
71f95d5
Merge branch 'ant-design:master' into master
leshalv Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/form/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export { ProFormContext } from '../utils';
export { LightWrapper } from './BaseForm';
export type { LightWrapperProps, ProFormInstance } from './BaseForm';

export type { SubmitterProps } from './BaseForm/Submitter';
Copy link

@gemini-code-assist gemini-code-assist bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and better maintainability, it would be preferable to export SubmitterProps through the BaseForm's barrel file (src/form/BaseForm/index.ts), similar to how other BaseForm-related types are handled.

This would involve two steps:

  1. Add export * from './Submitter'; to src/form/BaseForm/index.ts.
  2. Then, in this file (src/form/index.tsx), you could modify the existing export type for ./BaseForm to include SubmitterProps and remove the newly added line. The modified line would look like this: export type { LightWrapperProps, ProFormInstance, SubmitterProps } from './BaseForm';

This approach keeps the module's public API consolidated and easier to manage by avoiding direct dependencies on nested files from the top-level index file.

export * from './components';
export type {
FormListActionType,
Expand Down
Loading