Fix IRI generation with link parameter resources #7520
Merged
+206
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geekimo
force-pushed
the
fix/collection-id-with-link-parameter-provider-resources
branch
from
e74e08d to
2552e3a
Compare
Geekimo
commented
Nov 9, 2025
src/Symfony/Routing/IriConverter.php
Outdated
| { | ||
| $identifiers = $context['uri_variables'] ?? []; | ||
|
|
||
| foreach ($identifiers as $identifier) { |
Author
There was a problem hiding this comment.
At this point, resources loaded with the ReadLinkParameterProvider are still objects, so we need to replace them with their identifier's value.
Member
There was a problem hiding this comment.
we should never reach this path with non scalar identifiers, this is a highly costly path in API Platform imo its inside the identifiers extractor that we should handle this.
Author
There was a problem hiding this comment.
@soyuka In the getIdentifiersFromItem method, called at line 197 ?
Member
There was a problem hiding this comment.
probably, I need to take a look not sure what's happening.
Geekimo
force-pushed
the
fix/collection-id-with-link-parameter-provider-resources
branch
2 times, most recently
from
c4fd527 to
5b35943
Compare
soyuka
force-pushed
the
fix/collection-id-with-link-parameter-provider-resources
branch
6 times, most recently
from
5b63fe0 to
4437642
Compare
soyuka
force-pushed
the
fix/collection-id-with-link-parameter-provider-resources
branch
from
4437642 to
91847ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where link resources using the new ReadLinkParameterProvider fail to generate an IRI when using Hydra.