fix: add urllib3 compatibility for HTTPResponse getheader methods #15117
+65
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add compatibility layer for urllib3 HTTPResponse getheader and getheaders methods to support both old and new versions of urllib3. - Check for getheader/getheaders methods (urllib3 < 2.0) - Fall back to headers attribute (urllib3 >= 2.0) - Fixes AttributeError when using urllib3 2.x in Python SDK tests Signed-off-by: shuangkun <[email protected]>
Add Python script to automatically apply urllib3 compatibility fix to rest.py after OpenAPI Generator generates it. This ensures the fix persists even when the SDK is regenerated. - Create fix_urllib3_compat.py script to apply compatibility fix - Update Makefile to run the script after generation - Fixes compatibility with urllib3 >= 2.0 which removed getheader/getheaders methods Signed-off-by: shuangkun <[email protected]>
Member
|
Thanks @shuangkun! Since we already decided to remove the Python SDK, it's probably best to move forward with #14995 instead of adding hacks to patch it. |
Member
|
I've merged #14995 so we don't need this on |
Member
Author
Thanks！ |
Joibel
added a commit
that referenced
this pull request
Dec 8, 2025
…erry-pick #15117 for 3.7) (#15120) Signed-off-by: shuangkun <[email protected]> Co-authored-by: shuangkun <[email protected]>
Joibel
added a commit
that referenced
this pull request
Dec 8, 2025
…erry-pick #15117 for 3.6) (#15121) Signed-off-by: shuangkun <[email protected]> Co-authored-by: shuangkun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix test-python-sdk error
Add compatibility layer for urllib3 HTTPResponse getheader and getheaders methods to support both old and new versions of urllib3.
Motivation
Modifications
Verification
Documentation