fix: consider live workflows when checking HasMoreWorkflows #15118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangkun
force-pushed
the
fix/hasmore-workflows-consider-live
branch
from
87da3ce to
b74143b
Compare
Fix pagination logic to properly check for more workflows when there are many live workflows in the cluster. Previously, HasMoreWorkflows only checked the archive, ignoring live workflows. - Check if current offset+limit is still within live workflows range - If within live range, there are definitely more items - If beyond live range, check archive with adjusted offset - Fixes incorrect pagination when live workflows exceed offset+limit Signed-off-by: shuangkun <[email protected]>
shuangkun
force-pushed
the
fix/hasmore-workflows-consider-live
branch
from
b74143b to
57e0339
Compare
Member
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pagination logic to properly check for more workflows when there are many live workflows in the cluster. Previously, HasMoreWorkflows only checked the archive, ignoring live workflows.
Motivation
Modifications
Verification
Documentation