lib/composefs: Add error check for unsupported --download-only flag #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit (c325582) added --download-only support for the OSTree backend but did not add an error check for the composefs backend where this feature is not yet implemented. This commit adds a proper error message at the start of upgrade_composefs() to explicitly bail out when --download-only is used, matching the pattern used for other unsupported composefs features like --mutate-in-place and edit operations. Without this check, the flag would be silently ignored, potentially causing confusion for users expecting download-only behavior. Error message: "--download-only is not yet supported for composefs backend" Signed-off-by: Wei Shi <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly adds a check to prevent the use of the --download-only flag with the composefs backend, which does not yet support this feature. The change is straightforward and well-placed at the beginning of the upgrade_composefs function, ensuring it fails early with a clear error message. This improves the user experience by preventing silent failures and confusion. The implementation is consistent with how other unsupported features are handled in the composefs backend. The change is a good improvement.
Johan-Liebert1
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit (c325582) added --download-only support for the OSTree backend but did not add an error check for the composefs backend where this feature is not yet implemented.
This commit adds a proper error message at the start of upgrade_composefs() to explicitly bail out when --download-only is used, matching the pattern used for other unsupported composefs features like --mutate-in-place and edit operations.
Without this check, the flag would be silently ignored, potentially causing confusion for users expecting download-only behavior.
Error message: "--download-only is not yet supported for composefs backend"