weather: use lat/long when detecting location from IP #933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the weather back to using lat/long when automatically determining location from IP. The reason for this is, that we one can not really guarantee that the city part we get from
ipinfowill be recognized bywttr.in. For example for me, my IP resolves toCiudad del Este. First I tried to address the issue with spaces in the city name, but found out that even correctly formatted this city is not recognized bywttr.in.This should not break a users ability to use city in their config. Also, the only real change is on line 26, the rest is a renaming of the city variable to keep the code clean.