fix(java): skip settlement for error responses (4xx/5xx) #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o legacy subfolders
* fix legacy example builds * add next example * fix format * upgrade to next 16 * fix legacy build * fix e2e tests
* add next route wrapper * add protected api to example page * add unit tests * fix missing settle failure check * added e2e tests for withX402 * add SettleResponse to ProcessSettleResultResponse * add requirements to payment-header
…nVerifyFailure on failure
* add express fixes from v1 * add units test for express/hono * added fetch/axios unit tests
* Remove cdpClientKey and sessionTokenEndpoint from PaywallConfig Remove Onramp functionality from EvmPaywall Remove Coinbase fields from paywall template generation * Migrate site to @x402/next with v2 protocol support * Clean up tests * remove CDP onramp from core paywall * Update templates and build process * Format * Lockfile * mock templates for CI * Format * Generate new templates * Format
* update next/react versions * update site to next 16, tailwind 4 and fix env vars * fix initializeOnStart pattern
* fix ts examples * add clients/advanced/preferred-network example
Check response status before settlement in PaymentFilter. Skip settlement if handler returns 4xx/5xx to avoid charging users for failed requests. Matches Go/Python middleware behavior.
|
@madisoncarter1234 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Dec 5, 2025
CarsonRoscoe
force-pushed
the
development-v2
branch
from
cc79b72 to
0d42a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds response status code check before settlement in Java PaymentFilter. If the handler returns a 4xx or 5xx status code, settlement is skipped to prevent charging users for failed requests.
Problem
Currently the Java middleware settles payments regardless of whether the handler succeeded or failed. If the handler returns a 500 error, the user is still charged even though they didn't receive the content they paid for.
Go middleware already checks
writer.statusCode >= 400before settlement.Python middleware already checks
response.status_code >= 200 and response.status_code < 300before settlement.Changes
response.getStatus() >= 400check before callingfacilitator.settle()resp.getStatus()appropriatelyRelated