Skip to content

fix(java): skip settlement for error responses (4xx/5xx) #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madisoncarter1234 wants to merge 1 commit into
base: main
Choose a base branch
from
+63 −1
Open

fix(java): skip settlement for error responses (4xx/5xx) #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java/src/main/java/com/coinbase/x402/server/PaymentFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ public void doFilter(ServletRequest req,
chain.doFilter(req, res);

/* -------- settlement (return errors to user) ------------- */
// Don't settle if response failed (4xx/5xx status codes)
if (response.getStatus() >= 400) {
return;
}

try {
SettlementResponse sr = facilitator.settle(header, buildRequirements(path));
if (sr == null || !sr.success) {
Expand Down
59 changes: 58 additions & 1 deletion java/src/test/java/com/coinbase/x402/server/PaymentFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,10 @@ void validHeader() throws Exception {
VerificationResponse vr = new VerificationResponse();
vr.isValid = true;
when(fac.verify(eq(header), any())).thenReturn(vr);


// handler returns 200 OK
when(resp.getStatus()).thenReturn(HttpServletResponse.SC_OK);

// settlement succeeds
SettlementResponse sr = new SettlementResponse();
sr.success = true;
Expand All @@ -105,6 +108,60 @@ void validHeader() throws Exception {
verify(fac).settle(eq(header), any());
}

/* ------------ error response skips settlement ------------------------- */
@Test
void errorResponseSkipsSettlement() throws Exception {
when(req.getRequestURI()).thenReturn("/private");

PaymentPayload p = new PaymentPayload();
p.x402Version = 1;
p.scheme = "exact";
p.network = "base-sepolia";
p.payload = Map.of("resource", "/private");
String header = p.toHeader();
when(req.getHeader("X-PAYMENT")).thenReturn(header);

VerificationResponse vr = new VerificationResponse();
vr.isValid = true;
when(fac.verify(eq(header), any())).thenReturn(vr);

// handler returns 500 error
when(resp.getStatus()).thenReturn(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);

filter.doFilter(req, resp, chain);

verify(chain).doFilter(req, resp);
// settle should NOT be called for error responses
verify(fac, never()).settle(any(), any());
}

/* ------------ 4xx response skips settlement ---------------------------- */
@Test
void clientErrorResponseSkipsSettlement() throws Exception {
when(req.getRequestURI()).thenReturn("/private");

PaymentPayload p = new PaymentPayload();
p.x402Version = 1;
p.scheme = "exact";
p.network = "base-sepolia";
p.payload = Map.of("resource", "/private");
String header = p.toHeader();
when(req.getHeader("X-PAYMENT")).thenReturn(header);

VerificationResponse vr = new VerificationResponse();
vr.isValid = true;
when(fac.verify(eq(header), any())).thenReturn(vr);

// handler returns 404 error
when(resp.getStatus()).thenReturn(HttpServletResponse.SC_NOT_FOUND);

filter.doFilter(req, resp, chain);

verify(chain).doFilter(req, resp);
// settle should NOT be called for 4xx responses
verify(fac, never()).settle(any(), any());
}

/* ------------ facilitator rejects payment → 402 ------------------- */
@Test
void facilitatorRejection() throws Exception {
Expand Down