Skip to content

Conversation

@vemilano
Copy link
Contributor

@vemilano vemilano commented Dec 10, 2025

Description

Fix 2 things with cargo provider :

  • use same order to get / set a version for package or workspace
  • there is no workspace.version = "0.1.0" in spec to fix the version of a specific workspace member. It must be version = "0.1.0", even if it is a workspace member

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:

INFO    -  Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (120d514) to head (a1048a6).
⚠️ Report is 881 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1715      +/-   ##
==========================================
+ Coverage   97.33%   98.75%   +1.41%     
==========================================
  Files          42       60      +18     
  Lines        2104     2655     +551     
==========================================
+ Hits         2048     2622     +574     
+ Misses         56       33      -23     
Flag Coverage Δ
unittests 98.75% <100.00%> (+1.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism
Copy link
Collaborator

Hi @vemilano ,

We are planning to merge the branch v4-10-1, which contains changes in cargo_provider.py, into master branch.

You can resolve the potential conflict on this PR after we release 4.10.1.

cc @Lee-W

@bearomorphism bearomorphism changed the title fix: worskpace member with fixed version fix: workspace member with fixed version Dec 11, 2025
@bearomorphism
Copy link
Collaborator

nit: you have typo in your commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants