Fix bug where cleaner does not delete deletable partition group #7157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
Signed-off-by: Anna Tran <[email protected]>
anna-tran
force-pushed
the
fix-missing-deletion
branch
from
978c51a to
1268b1a
Compare
SungJin1212
reviewed
Dec 12, 2025
| * [BUGFIX] Ruler: Add XFunctions validation support. #7111 | ||
| * [BUGFIX] Querier: propagate Prometheus info annotations in protobuf responses. #7132 | ||
| * [BUGFIX] Scheduler: Fix memory leak by properly cleaning up query fragment registry. #7148 | ||
| * [BUGFIX] Compactor: Add back deletion of partition group info file even if not complete #7129 |
Member
There was a problem hiding this comment.
Can you fix a PR number?
Suggested change
| * [BUGFIX] Compactor: Add back deletion of partition group info file even if not complete #7129 | |
| * [BUGFIX] Compactor: Add back deletion of partition group info file even if not complete #7127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
A bug was introduced in this PR #7130 where the partition group file is no longer deleted even if it was marked as deletable because the cleaner would only delete partition groups that are both marked as
CanDeleteandIsCompleted. This causes invalid partition groups (e.g. a block from the group was deleted) to never be cleaned up.This PR adds back the deletion logic such that if no blocks were deleted for the deletable partition group, it can still be deleted. It also preserves the logic that partition groups are deleted on the second cleaner cycle if the parent blocks needed to be deleted first.
No tests were updated but this was tested in a distributed environment where that left partition groups dangling, and afterwards were cleaned up with the patched image including this change.
Which issue(s) this PR fixes:
Fixes #7129
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]