feat: skipe separator in begin-end closure option #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janproch
reviewed
Jan 3, 2025
| ...sqliteSplitterOptions, | ||
| }); | ||
|
|
||
| expect(output.length).toBe(1); |
Member
There was a problem hiding this comment.
please test exact output value, not only length
src/splitter.test.ts
Outdated
| ...sqliteSplitterOptions, | ||
| }); | ||
|
|
||
| expect(output.length).toBe(5); |
Member
There was a problem hiding this comment.
please test exact output value, not only length
| ); | ||
| }); | ||
|
|
||
| test('sqlite skipSeparatorBeginEnd', () => { |
Member
There was a problem hiding this comment.
please add the same test in lowercase, to ensure that it respect SQL case insensivity
Nybkox
force-pushed
the
feature/skip-separator-in-begin-end-option
branch
from
df49a9e to
ec306e4
Compare
Nybkox
force-pushed
the
feature/skip-separator-in-begin-end-option
branch
from
c29a691 to
9a6b37e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.