Fix CLI breakage on Linux #290
Merged
+34
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
kgprs
previously approved these changes
Dec 9, 2025
slimslenderslacks
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
It turned out that we were calling
docker.RunningInDockerCE()in the features setup before the plugin was ready, which would calldockerCli.Client().Info()too soon and break plugin integration. There's a bit of a chicken and egg problem there, since features inform the plugin commands beforePersistentPreRunEruns and sets up the plugin. To work around this, I changed the Docker Desktop detection on Linux so that it checks to see if the Docker Desktop is running by trying to connect to the backend socket.Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did