-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Split the Routing & Navigation article #36145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
danroth27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall structure of the new routing and navigation articles looks reasonable and I like the addition of the introductory sections. I made a just a few comments on some content issues I spotted. I do think we need to do a more detailed review of some of the sections in these articles. For example, I think the "Static versus interactive routing" section in the Routing article needs some clarification and I'd like the relationship to endpoint routing to be clearer in the following section. But let's move forward with getting this content refactoring in.
Co-authored-by: Daniel Roth <[email protected]>
|
@danroth27 ... Made the updates. See the last two commits for the changes (your accepted GH suggestions, then my branch changes on your other suggestions). See if "fragment routing" language/API works better for that example than "hashed routing." WRT ...
I'll open a follow-up issue. There wasn't a lot of time with the .NET 10 release and non-.NET 10 demands recently, including the Configuration and Logging overhaul PRs. I'm still fighting through issues just to get back to the batch of Blazorfy IT!™ issues that you opened, which are much-needed full article overhauls. I'm trying to make the main doc set's Fundamentals articles agnostic WRT UI stack as much as possible so that they're "Blazorfied" in the sense that they apply (and the examples work) across UI stacks. I'll circle around eventually to the new issue that I'm about to open, but I think your priority is still to get back into these overhaul/updates ASAP, and I'm working in that direction now 🏃♂️😅. I might be able to get one more done by 🎄🎅 time. @wadepickett, do you want to review? The main doc set article maps to your care at least. |
Fixes #35683
Fixes #36190
Splits roughly along
Routercomponent andNavLink/NavigationManagerlines.Not Found spans them, so there's a little bit on the
NotFoundPageparam in the Routing article with the rest in the Not Found responses section of the new Navigation article.I'm not planning a review/update of all sections at this time. It would slow me down by a couple of days in reaching the next Blazorfy IT!™ issue, but let me know if you would like to go for a full review on all of this guidance.
I'm inlining code examples because it's taking an awful lot of time ... i.e., 💰💰💰 ... to update sample cross-links every release for no great benefit. The code isn't changing and isn't likely to change for these examples. I'm stripping off the
<PageTitle>markup because it came in at 6.0, making the examples apply universally.Outlines
Routing article
OnNavigateAsyncOnNavigateAsync<Navigating>contentNavigation article
NavLinkcomponentnullNavLinkcomponents via reflectionInternal previews
Toggle expand/collapse