-
Notifications
You must be signed in to change notification settings - Fork 745
Add --skip-path option to Aspire CLI installation scripts #13317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: radical <[email protected]>
Co-authored-by: radical <[email protected]>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13317Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13317" |
|
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a --skip-path option to all Aspire CLI installation scripts, enabling portable installations that don't modify PATH environment variables.
Key changes:
- Adds flag/parameter to skip PATH configuration in all four installation scripts (bash and PowerShell variants)
- Wraps PATH update logic in conditional checks based on the new flag
- Includes documentation and usage examples for the new option
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/scripts/get-aspire-cli.sh | Adds --skip-path flag and conditionally skips GitHub Actions PATH, shell profile updates, and current session PATH modifications |
| eng/scripts/get-aspire-cli.ps1 | Adds -SkipPath parameter with help text and example, conditionally skips PATH environment updates |
| eng/scripts/get-aspire-cli-pr.sh | Adds --skip-path flag for PR-specific installations with conditional PATH configuration logic |
| eng/scripts/get-aspire-cli-pr.ps1 | Adds -SkipPath parameter with documentation and example for PR-based CLI installations |
Description
Adds
--skip-path(bash) /-SkipPath(PowerShell) option to all Aspire CLI installation scripts, enabling portable installations that don't modify PATH.Scripts updated:
eng/scripts/get-aspire-cli.sheng/scripts/get-aspire-cli.ps1eng/scripts/get-aspire-cli-pr.sheng/scripts/get-aspire-cli-pr.ps1When enabled, skips:
Usage:
Fixes #9080
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplateOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.