Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ private TokenCredential Credentials
if (_clientId == null)
{
// Local development scenario. Use the default credential.
return new DefaultAzureCredential();
return new DefaultAzureCredential(); // CodeQL [SM05137] This is not a security issue as this is for local development only.
}

return new DefaultAzureCredential(new DefaultAzureCredentialOptions { ManagedIdentityClientId = _clientId });
return new DefaultAzureCredential(new DefaultAzureCredentialOptions { ManagedIdentityClientId = _clientId }); // CodeQL [SM05137] This is not a security issue since this is only used for pipeline builds.
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ private static TokenCredential CreateDefaultCredential(AzureBlobEgressProviderOp
credOptions.ManagedIdentityClientId = options.ManagedIdentityClientId;
}

return new DefaultAzureCredential(credOptions);
return new DefaultAzureCredential(credOptions); // CodeQL [SM05137] Guidance here is to ensure that credential lookup is deterministic by using an environment variable. We accomplish this through settings and only including Managed Identity and Workload credentials, and do not want to introduce a breaking change.
}

private static DefaultAzureCredentialOptions GetDefaultCredentialOptions() =>
Expand Down