[Foundation] Fix nullability in NSSet. #24309

rolfbjarne · 2025-11-20T18:48:53Z

This is file 19 of 47 files with nullability disabled in Foundation.

Changes:

Enabled nullable reference types
Made operator return types nullable where appropriate (operator +, operator -)
Made operator parameters nullable for consistency
Improved null handling in operators to return null when appropriate
Added null-forgiving operator to Runtime.GetNSObject call in MakeNSObjectSet
Replaced "To be added." XML documentation with proper documentation for all members
Added see cref attributes throughout for better cross-referencing
Removed unnecessary whitespace in XML comments while preserving correct indentation
Improved XML documentation formatting and consistency
Used typeparamref for generic type parameters in documentation
Added comprehensive documentation for all operators
Enhanced remarks and examples in XML documentation

Contributes towards #17285.

This is file 19 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullable reference types - Made operator return types nullable where appropriate (operator +, operator -) - Made operator parameters nullable for consistency - Improved null handling in operators to return null when appropriate - Added null-forgiving operator to Runtime.GetNSObject call in MakeNSObjectSet - Replaced "To be added." XML documentation with proper documentation for all members - Added see cref attributes throughout for better cross-referencing - Removed unnecessary whitespace in XML comments while preserving correct indentation - Improved XML documentation formatting and consistency - Used typeparamref for generic type parameters in documentation - Added comprehensive documentation for all operators - Enhanced remarks and examples in XML documentation Contributes towards #17285.

Copilot

Pull Request Overview

This PR enables nullable reference types for the NSSet class in Foundation, which is part of a larger effort to enable nullability across the Foundation namespace. The changes include making operator parameters and return types nullable where appropriate, adding null-forgiving operators where needed, and significantly improving XML documentation throughout the file.

Key Changes

Enabled nullable reference types by adding #nullable enable
Updated operator signatures to accept and return nullable types (NSSet? and NSOrderedSet?)
Added null-forgiving operator to Runtime.GetNSObject call in MakeNSObjectSet
Replaced all "To be added." placeholder documentation with comprehensive, descriptive XML comments
Removed 4 documentation-related known test failures for the documented operators

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Foundation/NSSet.cs	Enabled nullable reference types, updated operator nullability, improved all XML documentation with proper formatting and cross-references
tests/cecil-tests/Documentation.KnownFailures.txt	Removed 4 known failures for NSSet operators that are now properly documented

src/Foundation/NSSet.cs

…ullability-19-nsset

vs-mobiletools-engineering-service2 · 2025-12-04T18:26:16Z

✅ [CI Build #91c8bd0] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 91c8bd04fb3abedbf32bfc1449e538ac99a65e1c [PR build]

vs-mobiletools-engineering-service2 · 2025-12-04T18:42:08Z

✅ [PR Build #91c8bd0] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 91c8bd04fb3abedbf32bfc1449e538ac99a65e1c [PR build]

vs-mobiletools-engineering-service2 · 2025-12-04T19:30:45Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 91c8bd04fb3abedbf32bfc1449e538ac99a65e1c [PR build]

vs-mobiletools-engineering-service2 · 2025-12-04T19:58:16Z

✅ [CI Build #91c8bd0] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 91c8bd04fb3abedbf32bfc1449e538ac99a65e1c [PR build]

vs-mobiletools-engineering-service2 · 2025-12-04T20:34:38Z

💻 [CI Build #91c8bd0] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 91c8bd04fb3abedbf32bfc1449e538ac99a65e1c [PR build]

vs-mobiletools-engineering-service2 · 2025-12-04T20:35:39Z

💻 [CI Build #91c8bd0] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 91c8bd04fb3abedbf32bfc1449e538ac99a65e1c [PR build]

vs-mobiletools-engineering-service2 · 2025-12-04T20:35:56Z

💻 [CI Build #91c8bd0] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 91c8bd04fb3abedbf32bfc1449e538ac99a65e1c [PR build]

vs-mobiletools-engineering-service2 · 2025-12-04T20:53:10Z

💻 [CI Build #91c8bd0] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 91c8bd04fb3abedbf32bfc1449e538ac99a65e1c [PR build]

vs-mobiletools-engineering-service2 · 2025-12-04T21:00:54Z

💻 [CI Build #91c8bd0] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 91c8bd04fb3abedbf32bfc1449e538ac99a65e1c [PR build]

vs-mobiletools-engineering-service2 · 2025-12-05T08:55:28Z

🚀 [CI Build #91c8bd0] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 123 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 91c8bd04fb3abedbf32bfc1449e538ac99a65e1c [PR build]

rolfbjarne enabled auto-merge (squash) November 20, 2025 18:48

rolfbjarne requested a review from Copilot November 20, 2025 18:48

Copilot started reviewing on behalf of rolfbjarne November 20, 2025 18:49 View session

Copilot finished reviewing on behalf of rolfbjarne November 20, 2025 18:52

This comment has been minimized.

Sign in to view

Copilot AI reviewed Nov 20, 2025

View reviewed changes

src/Foundation/NSSet.cs Show resolved Hide resolved

dalexsoto approved these changes Nov 20, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

13d3857

…ullability-19-nsset

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

91c8bd0

…ullability-19-nsset

This comment has been minimized.

Sign in to view

[Foundation] Fix nullability in NSSet. #24309

Are you sure you want to change the base?

[Foundation] Fix nullability in NSSet. #24309

Uh oh!

Conversation

rolfbjarne commented Nov 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 4, 2025

✅ [CI Build #91c8bd0] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 4, 2025

✅ [PR Build #91c8bd0] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 4, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 4, 2025

✅ [CI Build #91c8bd0] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 4, 2025

💻 [CI Build #91c8bd0] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 4, 2025

💻 [CI Build #91c8bd0] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 4, 2025

💻 [CI Build #91c8bd0] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 4, 2025

💻 [CI Build #91c8bd0] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 4, 2025

💻 [CI Build #91c8bd0] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 5, 2025

🚀 [CI Build #91c8bd0] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants