-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix iOS SearchHandler suggestions list gap on iPhone #32931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: jfversluis <[email protected]>
Co-authored-by: jfversluis <[email protected]>
|
/azp run MAUI-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@copilot this fix is confirmed to not work. Can you have a look at the workaround in #32930 (comment) that does work. It looks a bit hacky though, is there a decent way to implement this directly in our codebase? |
…resentation Co-authored-by: jfversluis <[email protected]>
I've updated the fix based on the workaround from @pictos. The previous approach setting The new fix in commit 20c776f sets |
|
/azp run MAUI-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
On iPhone, when tapping a SearchHandler, the navigation bar hides and the search bar animates upward. The suggestions list was not following this movement, creating a visible gap. iPad and Android work correctly.
Root cause: When
HidesNavigationBarDuringPresentationistrue(the iOS default), the navigation bar hides during search presentation and the search bar animates upward, but the suggestions list doesn't follow properly on iPhone.Fix: Set
HidesNavigationBarDuringPresentation = falseandObscuresBackgroundDuringPresentation = falseon theUISearchControllerwhen it's created inShellPageRendererTracker.AttachSearchController(). This prevents the navigation bar from hiding during search presentation, keeping the suggestions list correctly attached to the search bar.This approach is based on a working workaround provided by @pictos in the issue comments.
Issues Fixed
Fixes #32930
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.