-
-
Notifications
You must be signed in to change notification settings - Fork 104
Added mute microphone switch #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Includes adjustment to script to handle mute option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a mute microphone functionality to the M5Stack Atom Echo device configuration. The implementation includes a toggle switch that allows users to mute the microphone and provides visual feedback through LED indicators.
- Added a mute microphone template switch with proper state restoration
- Modified the reset_led script to show red LED when microphone is muted
- Updated the start_wake_word script to check mute status before starting wake word detection
Comments suppressed due to low confidence (1)
kahrendt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Starting and stopping the wake word was how we used to handle muting on the Voice Preview Edition firmware, but ESPHome microphones now have the microphone.mute and microphone.unmute actions. You could simplify this significantly by just having the template switch call those two actions as needed (while adjusting the LEDs as appropriate) instead of directly messing with the wake words.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
That's logical, but seeing as the M5 Stack can't currently compile as mentioned here, I'm reluctant to change this as I can't use it anyway. :-/ |
|
Hi, is the compile issue really a problem today? I have 3 m5stacks and all of them being build correctly and are working. I would really appriciate the mute option. |
Includes adjustment to script to handle mute option