Skip to content

Conversation

@loryanstrant
Copy link

Includes adjustment to script to handle mute option

Includes adjustment to script to handle mute option
Copilot AI review requested due to automatic review settings August 8, 2025 06:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a mute microphone functionality to the M5Stack Atom Echo device configuration. The implementation includes a toggle switch that allows users to mute the microphone and provides visual feedback through LED indicators.

  • Added a mute microphone template switch with proper state restoration
  • Modified the reset_led script to show red LED when microphone is muted
  • Updated the start_wake_word script to check mute status before starting wake word detection
Comments suppressed due to low confidence (1)

@jesserockz jesserockz requested a review from kahrendt October 22, 2025 01:27
Copy link
Contributor

@kahrendt kahrendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Starting and stopping the wake word was how we used to handle muting on the Voice Preview Edition firmware, but ESPHome microphones now have the microphone.mute and microphone.unmute actions. You could simplify this significantly by just having the template switch call those two actions as needed (while adjusting the LEDs as appropriate) instead of directly messing with the wake words.

@esphome esphome bot marked this pull request as draft October 22, 2025 15:11
@esphome
Copy link
Contributor

esphome bot commented Oct 22, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@loryanstrant
Copy link
Author

Thanks for working on this!

Starting and stopping the wake word was how we used to handle muting on the Voice Preview Edition firmware, but ESPHome microphones now have the microphone.mute and microphone.unmute actions. You could simplify this significantly by just having the template switch call those two actions as needed (while adjusting the LEDs as appropriate) instead of directly messing with the wake words.

That's logical, but seeing as the M5 Stack can't currently compile as mentioned here, I'm reluctant to change this as I can't use it anyway. :-/

@Dillton
Copy link

Dillton commented Nov 12, 2025

Hi, is the compile issue really a problem today? I have 3 m5stacks and all of them being build correctly and are working. I would really appriciate the mute option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants