Skip to content

Conversation

@henrybear327
Copy link
Contributor

…ump go.opentelemetry.io/otel/trace from 1.30.0 to 1.31.0

Reference:
- etcd-io#18732
- etcd-io#18735

Signed-off-by: Chun-Hung Tseng <[email protected]>
… google.golang.org/genproto/googleapis/rpc from v0.0.0-20240924160255-9d4c2d233b61 to v0.0.0-20241007155032-5fefd90f89a9

Also addressed inconsistent versions for dependency: google.golang.org/genproto/googleapis/rpc

Reference:
- etcd-io#18729

Signed-off-by: Chun-Hung Tseng <[email protected]>
…ce/otlptracegrpc from 1.30.0 to 1.31.0, github.com/rogpeppe/go-internal from v1.12.0 to v1.13.1, and google.golang.org/genproto/googleapis/api from v0.0.0-20240924160255-9d4c2d233b61 to v0.0.0-20241007155032-5fefd90f89a9

Also addressed inconsistent versions for dependency: github.com/rogpeppe/go-internal and google.golang.org/genproto/googleapis/api

Reference:
- etcd-io#18736

Signed-off-by: Chun-Hung Tseng <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (3869f0e) to head (9a0b775).

Current head 9a0b775 differs from pull request most recent head 8c538cd

Please upload reports for the commit 8c538cd to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18755      +/-   ##
==========================================
- Coverage   68.76%   68.69%   -0.08%     
==========================================
  Files         420      420              
  Lines       35501    35501              
==========================================
- Hits        24412    24386      -26     
- Misses       9657     9682      +25     
- Partials     1432     1433       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3869f0e...8c538cd. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @henrybear327

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 44c3918 into etcd-io:main Oct 20, 2024
21 checks passed
@henrybear327 henrybear327 deleted the dependencies/10_20_24 branch October 20, 2024 13:18
jmhbnz added a commit that referenced this pull request Oct 27, 2024
[2024-10-20] Bump dependency updates identified by dependabot #18755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants