Skip to content

Conversation

@serathius
Copy link
Member

@serathius serathius commented Oct 23, 2024

Should reduce number of flakes due to etcd being overloaded by too many compaction at once

@serathius
Copy link
Member Author

@serathius serathius force-pushed the robustness-compaction-evenly branch from 9ac9431 to 5af18cd Compare October 23, 2024 19:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (867bd26) to head (2f277dd).

Current head 2f277dd differs from pull request most recent head 16221d5

Please upload reports for the commit 16221d5 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18771      +/-   ##
==========================================
- Coverage   68.77%   68.69%   -0.08%     
==========================================
  Files         420      420              
  Lines       35508    35508              
==========================================
- Hits        24420    24392      -28     
- Misses       9661     9686      +25     
- Partials     1427     1430       +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867bd26...16221d5. Read the comment docs.

@serathius serathius force-pushed the robustness-compaction-evenly branch from 5af18cd to 16221d5 Compare October 23, 2024 21:47
@serathius
Copy link
Member Author

/retest

@serathius
Copy link
Member Author

cc @jmhbnz

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit c2bf879 into etcd-io:main Oct 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants