Skip to content

Conversation

@joshjms
Copy link
Member

@joshjms joshjms commented Jul 7, 2025

Ref: kubernetes/test-infra#32754
Continuation of #20168
Partial backport of #19305

Rename the input "IMAGE" to "TEST_IMAGE" to avoid clashing with the environment variable from the Prow infrastructure.

Results in pj-on-kind
% '/home/prow/go/src/github.com/etcd-io/etcd/scripts/test_images.sh'
a92a0d16d13e6ac3add6d08bb8edb7b7b8541bc07ac21804ffb3f134862c638d
Succesfully tested etcd local image v3.5.99-amd64
Correct Architecture v3.5.99-amd64
Correct Architecture v3.5.99-arm64
Correct Architecture v3.5.99-ppc64le
Correct Architecture v3.5.99-s390x
test_etcd
'release_tests' completed at Mon Jul  7 09:39:51 UTC 2025
SUCCESS
+ EXIT_VALUE=0
+ set +o xtrace
Cleaning up after docker in docker.
================================================================================
Cleaning up after docker
Stopping Docker: dockerProgram process in pidfile '/var/run/docker-ssd.pid', 1 process(es), refused to die.
================================================================================
Done cleaning up after docker in docker.

/cc @ivanvc @abdurrehman107

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Partial backport of etcd-io#19305

Refactor scripts/test_images.sh
* Rename the input "IMAGE" to "TEST_IMAGE" to avoid clashing with the
  environment variable from the Prow infrastructure.

Co-authored-by: ivanvc <[email protected]>
Signed-off-by: joshjms <[email protected]>
@abdurrehman107
Copy link
Member

Just out of curiosity why are we changing it to TEST_IMAGE from IMAGE?

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @joshjms

@ivanvc
Copy link
Member

ivanvc commented Jul 7, 2025

Just out of curiosity why are we changing it to TEST_IMAGE from IMAGE?

@abdurrehman107, refer to #19305

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @joshjms.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit d81dcb1 into etcd-io:release-3.5 Jul 8, 2025
35 checks passed
@ivanvc ivanvc mentioned this pull request Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants