-
Notifications
You must be signed in to change notification settings - Fork 10.2k
fix(mixin): Fix alerts aggregation by improving config defaults #20996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: v-zhuravlev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @v-zhuravlev. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: v-zhuravlev <[email protected]>
|
@v-zhuravlev: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| // that are about an etcd cluster as a whole. For example, if etcd | ||
| // instances are deployed on K8s, you will likely want to change | ||
| // this to 'instance, pod'. | ||
| etcd_instance_labels: 'instance', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls see comment right above the config item.
Users may also run etcd in non-K8s environment.
If not all labels are mentioned you might get 3 similar alerts (as etcdInsufficientMembers) instead of just one per cluster.
podandinstanceare always present in typical k8s prometheus setups so best to provide those as defaults , so alerts work properly in most cases.