Deal with non-strings in is_uuid? #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In d971ad5 the method was rewritten with the intention of being compatible with Ruby 3.3 where =~ is only defined on strings. A problem with this is that /regex/.match?(nil) works, but /regex/.match?(42) raises a TypeError. It would have been broken with the old code on Ruby 3.3 as well, but only raised a deprecation warning on prior versions. Fixes: d971ad5 ("Fix warning on nil comparison")
nofaralfasi
approved these changes
Apr 20, 2025
Collaborator
nofaralfasi
left a comment
nofaralfasi
left a comment
There was a problem hiding this comment.
Fixed the issue for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In d971ad5 the method was rewritten with the intention of being compatible with Ruby 3.3 where
=~is only defined on strings.A problem with this is that
/regex/.match?(nil)works, but/regex/.match?(42)raises aTypeError. It would have been broken with the old code on Ruby 3.3 as well, but only raised a deprecation warning on prior versions.Fixes: d971ad5 ("Fix warning on nil comparison")
This doesn't implement tests because there is no testing infrastructure at all, but given it led to a regression in Foreman that would be a good idea to do.