fix(statusline): set hl_group for statusline separators #616
Conversation
danielwe
force-pushed
the
statusline_sep_hl
branch
from
f38e019 to
5ede517
Compare
danielwe
force-pushed
the
statusline_sep_hl
branch
from
5ede517 to
5dd5c9f
Compare
|
This PR is stale because it has been open 30 days with no activity. |
danielwe
force-pushed
the
statusline_sep_hl
branch
from
5dd5c9f to
c07851e
Compare
|
Any comments on this? Been using it locally without issue for a month+. |
github-actions
bot
removed
the
stale
|
nvim-lualine/lualine.nvim#1368 was merged, so this is the only piece missing to address the miscolored statusline gaps. Anything you'd like me to do to make this mergeable? |
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
|
Ready for comments whenever you are :) |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
|
keeping this alive |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
|
keep alive |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
|
I think this is worth keeping alive |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
stale
|
Time to un-stale this again! Still relevant and ready to go. |
github-actions
bot
removed
the
stale
|
Hi @folke, Is there any reason why this PR is ignored? |
2 participants
Description
Currently, statusline segments have custom highlight groups, but the separators between the segments don't get any highlight group applied, resulting gaps/discontinuities in the statusline background with most colorschemes. This PR applies the highlight group provided to
trouble.statusline, if any, to the separators as well as to any segments that don't supply their own highlight group.The fix involves a slight refactor of the
fix_statuslinefunctionality such that segment hl backgrounds are substituted in advance rather than via post hoc search and replace.I also added a clause to filter out empty segments which would otherwise result in extraneous separators, usually appended to the end of the statusline string. Let me know if these empty segments/extra separators were intentional and I'll revert that change.
Related Issue(s)
The author closed the issue when a workaround was posted, but I figured it would be worthwhile to fix this properly in the plugin.
Screenshots
Before: Note the gap between
openandview:waitas well as the double gap afterview:waitAfter: The single remaining gap after
view:waitis due to a bug in lualine.nvim; I'm submitting a PR there tooEDIT: With nvim-lualine/lualine.nvim#1368: No gaps!
